update changelog-3.4 to protection for rangePermCache with a RW lock #14231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahrtr
reviewed
Jul 19, 2022
CHANGELOG/CHANGELOG-3.4.md
Outdated
| @@ -14,7 +14,8 @@ See [code changes](https://github.com/etcd-io/etcd/compare/v3.4.18...v3.4.19) an | |||
| - Fix [lease leak issue due to tokenProvider isn't enabled when restoring auth store from a snapshot](https://github.com/etcd-io/etcd/pull/13206). | |||
| - Fix [the race condition between goroutine and channel on the same leases to be revoked](https://github.com/etcd-io/etcd/pull/14150). | |||
| - Fix [lessor may continue to schedule checkpoint after stepping down leader role](https://github.com/etcd-io/etcd/pull/14150). | |||
|
|
|||
| - Fix [Protect rangePermCache with a RW lock correctly](https://github.com/etcd-io/etcd/pull/14230) | |||
There was a problem hiding this comment.
Thanks @mitake .
3.4.19 has already been released, this PR will be included in 3.4.20.
Please feel free to create a new section for 3.4.20, or let me take care of all items once 3.4.20 is released.
There was a problem hiding this comment.
Got it, let me update this PR.
There was a problem hiding this comment.
@ahrtr Updated, could you check?
mitake
force-pushed
the
changelog-3.4-for-pr-14230
branch
from
fdee21c
to
f8e65cd
Compare
Signed-off-by: Hitoshi Mitake <h.mitake@gmail.com>
mitake
force-pushed
the
changelog-3.4-for-pr-14230
branch
from
f8e65cd
to
97222a5
Compare
Codecov Report
@@ Coverage Diff @@
## main #14231 +/- ##
==========================================
- Coverage 75.58% 75.08% -0.51%
==========================================
Files 456 456
Lines 36919 36919
==========================================
- Hits 27904 27719 -185
- Misses 7299 7450 +151
- Partials 1716 1750 +34
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
ahrtr
approved these changes
Jul 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hitoshi Mitake h.mitake@gmail.com